From b4ff535128e6c169d2b4966e6227faa511780621 Mon Sep 17 00:00:00 2001
From: undido <firekid109@hotmail.com>
Date: Tue, 16 Apr 2013 19:09:58 -0300
Subject: update to pages.php minor exploit

A lot of bans can be removed from a tinyboard database because it isn't limited A staff member could select 100 users all at once with a simple javascript function and unban them all this needs to be limited because a staff member on an image board if they feel hostile they can just remove all bans on the tinyboard site easily without being limited to how many people they can unban at a time, this adds an option to limit it.
---
 inc/mod/pages.php | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

(limited to 'inc/mod/pages.php')

diff --git a/inc/mod/pages.php b/inc/mod/pages.php
index 5d736a1a..6a780474 100644
--- a/inc/mod/pages.php
+++ b/inc/mod/pages.php
@@ -651,7 +651,8 @@ function mod_bans($page_no = 1) {
 			if (preg_match('/^ban_(\d+)$/', $name, $match))
 				$unban[] = $match[1];
 		}
-		
+		if (isset($config['mod']['unban_limit'])){
+		if (count($unban) <= $config['mod']['unban_limit'] || $config['mod']['unban_limit'] == -1){ 
 		if (!empty($unban)) {
 			query('DELETE FROM `bans` WHERE `id` = ' . implode(' OR `id` = ', $unban)) or error(db_error());
 		
@@ -659,7 +660,21 @@ function mod_bans($page_no = 1) {
 				modLog("Removed ban #{$id}");
 			}
 		}
+		} else {
+		error(sprintf($config['error']['toomanyunban'], $config['mod']['unban_limit'], count($unban) ));
+		}
+		
+	} else {
+		
+			if (!empty($unban)) {
+			query('DELETE FROM `bans` WHERE `id` = ' . implode(' OR `id` = ', $unban)) or error(db_error());
+		
+			foreach ($unban as $id) {
+				modLog("Removed ban #{$id}");
+			}
+		}	
 		
+	}
 		header('Location: ?/bans', true, $config['redirect_http']);
 	}
 	
-- 
cgit v1.3


From 3bcc87caf294cd67f221854d1dc13065706f5a81 Mon Sep 17 00:00:00 2001
From: Macil Tech <maciltech@gmail.com>
Date: Wed, 27 Mar 2013 22:09:39 +0800
Subject: Fix PM count caching.

cache::get() returns null if the key wasn't found (at least when using
the Redis cache backend).
---
 inc/mod/auth.php  | 2 +-
 inc/mod/pages.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

(limited to 'inc/mod/pages.php')

diff --git a/inc/mod/auth.php b/inc/mod/auth.php
index f594af4b..d4a2ea1c 100644
--- a/inc/mod/auth.php
+++ b/inc/mod/auth.php
@@ -125,7 +125,7 @@ if (isset($_COOKIE[$config['cookies']['mod']])) {
 function create_pm_header() {
 	global $mod, $config;
 	
-	if ($config['cache']['enabled'] && ($header = cache::get('pm_unread_' . $mod['id'])) !== false) {
+	if ($config['cache']['enabled'] && ($header = cache::get('pm_unread_' . $mod['id'])) != false) {
 		if ($header === true)
 			return false;
 	
diff --git a/inc/mod/pages.php b/inc/mod/pages.php
index cf06e7d9..726ed735 100644
--- a/inc/mod/pages.php
+++ b/inc/mod/pages.php
@@ -89,7 +89,7 @@ function mod_dashboard() {
 		}
 	}
 	
-	if (!$config['cache']['enabled'] || ($args['unread_pms'] = cache::get('pm_unreadcount_' . $mod['id'])) === false) {
+	if (!$config['cache']['enabled'] || ($args['unread_pms'] = cache::get('pm_unreadcount_' . $mod['id'])) == false) {
 		$query = prepare('SELECT COUNT(*) FROM `pms` WHERE `to` = :id AND `unread` = 1');
 		$query->bindValue(':id', $mod['id']);
 		$query->execute() or error(db_error($query));
-- 
cgit v1.3


From be1e55b9d63bd4cdb910206e9e99ecf83ca7ffde Mon Sep 17 00:00:00 2001
From: Macil Tech <maciltech@gmail.com>
Date: Fri, 1 Mar 2013 05:56:44 +0800
Subject: Fix result page after installing theme getting doubled up.

---
 inc/mod/pages.php | 1 +
 1 file changed, 1 insertion(+)

(limited to 'inc/mod/pages.php')

diff --git a/inc/mod/pages.php b/inc/mod/pages.php
index 726ed735..22018d31 100644
--- a/inc/mod/pages.php
+++ b/inc/mod/pages.php
@@ -1832,6 +1832,7 @@ function mod_theme_configure($theme_name) {
 			'result' => $result,
 			'message' => $message,
 		));
+		return;
 	}
 
 	$settings = themeSettings($theme_name);
-- 
cgit v1.3