Fixing ability to call moderation functionality with PHP-8 by filtering out named parameters. as per https://github.com/vichan-devel/vichan/commit/d6ea8db5ef0af262fd8823c1bebb84efa06214a9 and https://github.com/vichan-devel/vichan/commit/401b5066915af3241fc5002e01b35e18ce0c8872

1 files changed, 6 insertions, 1 deletions

diff --git a/mod.php b/mod.php
index 50be3471..4212a46b 100644
--- a/mod.php
+++ b/mod.php
@@ -183,7 +183,7 @@ foreach ($pages as $key => $callback) {
 	if (is_string($callback) && preg_match('/^secure /', $callback))
 		$key .= '(/(?P<token>[a-f0-9]{8}))?';
 	$key = str_replace('\%b', '?P<board>' . sprintf(substr((string) $config['board_path'], 0, -1), $config['board_regex']), $key);
-	$new_pages[@$key[0] == '!' ? $key : '!^' . $key . '(?:&[^&=]+=[^&]*)*$!u'] = $callback;
+	$new_pages[(!empty($key) and $key[0] == '!') ? $key : '!^' . $key . '(?:&[^&=]+=[^&]*)*$!u'] = $callback;
 }
 $pages = $new_pages;
 
@@ -228,6 +228,11 @@ foreach ($pages as $uri => $handler) {
 			$debug['time']['parse_mod_req'] = '~' . round((microtime(true) - $parse_start_time) * 1000, 2) . 'ms';
 		}
 		
+		if (is_array($matches)) {
+                        // we don't want to call named parameters (PHP 8)
+                        $matches = array_values($matches);
+                }
+
 		if (is_string($handler)) {
 			if ($handler[0] == ':') {
 				header('Location: ' . substr($handler, 1),  true, $config['redirect_http']);